[common]: allow configuring StatefulSet governing Service name - #186
Merged
Conversation
Signed-off-by: Reto Kupferschmid <kupferschmid@puzzle.ch>
wthhub
approved these changes
Aug 12, 2026
wthhub
left a comment
wthhub
left a comment
Contributor
There was a problem hiding this comment.
Looks great, thanks for contributing!
wthhub
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes the
commonchart's StatefulSet governing Service name mismatch:common.statefulset'sspec.serviceName(<library.name>-<component>) never matched the Service name produced bycommon.service(<library.name>-<component>-<servicename>), so the governing/headless service link was broken for every StatefulSet defined via this chart.Adds an optional
controller.serviceNamefield. When set,spec.serviceNameis rendered as<library.name>-<component>-<controller.serviceName>, matching aservices.<name>entry under the same component. When unset, the previous naming is kept for backwards compatibility.Which issue this PR fixes
fixes #185
Notes for Reviewer:
charts/common/templates/_statefulset.yaml: conditionally renderserviceNameusingcontroller.serviceNamewhen present.charts/common/values.schema.json: added optionalserviceNamestring undercontroller.charts/common/values.yaml: documented the new field.12.8.0→12.9.0(additive/backwards-compatible change).Checklist:
[chart]: Changed SomethingREADME.md.gotmplfile and executedhelm-docs